#1695 clean python compiled binaries for non *.py code
Merged 2 years ago by tkopecek. Opened 2 years ago by julian8628.
julian8628/koji clean  into  master

file modified
+1 -1
@@ -7,7 +7,7 @@ 

  	@echo "nothing to make.  try make install"

  

  clean:

- 	rm -f *.o *.so *.pyc *~

+ 	rm -f *.o *.so *.pyc *~ kojidc

  

  

  _install:

file modified
+1 -1
@@ -12,7 +12,7 @@ 

  	@echo "nothing to make.  try make install"

  

  clean:

- 	rm -f *.o *.so *.pyc *~

+ 	rm -f *.o *.so *.pyc *~ kojic

  

  install:

  	@if [ "$(DESTDIR)" = "" ]; then \

file modified
+1
@@ -7,6 +7,7 @@ 

  

  clean:

  	rm -f *.o *.so *.pyc *~

+ 	for b in $(BINFILES); do rm -f $${b}c; done

  

  _install:

  	@if [ "$(DESTDIR)" = "" ]; then \

file modified
+1 -1
@@ -7,7 +7,7 @@ 

  	@echo "nothing to make.  try make install"

  

  clean:

- 	rm -f *.o *.so *.pyc *~ kojikamid

+ 	rm -f *.o *.so *.pyc *~ kojikamid kojikamidc kojivmdc

  

  kojikamid: kojikamid.py

  	bash fix_kojikamid.sh >kojikamid

fixes: #1698

It would lead build failed sometimes.

I met it when generating coverage report phase of make test in rhel7 docker container

cli/kojic   NotPython: Couldn't parse '/opt/koji/cli/kojic' as Python source: 'EOF in multi-line statement' at (146, 0)

@julian8628 Can you create issue for this, reference it and plan for 1.20?

...and please fix commit message, so it references that issue.

rebased onto 6587c44

2 years ago

:thumbsup: (will merge after 1.19)

Commit a24af06 fixes this pull-request

Pull-Request has been merged by tkopecek

2 years ago

Metadata Update from @tkopecek:
- Pull-request tagged with: no-qe

2 years ago