PR#1398: kojid: Download only 'origin' - koji

koji

#1398 kojid: Download only 'origin'

Merged 4 years ago by mikem. Opened 5 years ago by ignatenkobrain.

ignatenkobrain/koji origin-librepo into master

Igor Gnatenko • 5 years ago

a66b4dd

builder/kojid

file modified

		`@@ -739,6 +739,9 @@`
		`h.setopt(librepo.LRO_REPOTYPE, librepo.LR_YUMREPO)`
		`h.setopt(librepo.LRO_URLS, [repo_url])`
		`h.setopt(librepo.LRO_DESTDIR, tmpdir)`
		`+ # We are using this just to find out location of 'origin',`
		`+ # we don't even need to download it since we use openRemoteFile`
		`+ h.setopt(librepo.LRO_YUMDLIST, [])`
		`h.perform(r)`
		`pkgorigins = r.getinfo(librepo.LRR_YUM_REPOMD)['origin']['location_href']`
		`koji.util.rmtree(tmpdir)`

ignatenkobrain commented 5 years ago

We have pretty slow connection from s390x koji which helped to uncover
this part. Kojid downloads all files from repomd.xml (incl. filelists)
which is really big. What we really want is just 'origin' (used by Koji
only).

Signed-off-by: Igor Gnatenko ignatenkobrain@fedoraproject.org

ignatenkobrain commented 5 years ago

FTR, I didn't test it since I don't really have place to do so :)

ignatenkobrain commented 5 years ago

Testing this with some librepo code (outside of koji), patch should be correct. In Fedora it should save around 140M per architecture when repo changes.

ignatenkobrain commented 5 years ago

            pkgorigins = r.getinfo(librepo.LRR_YUM_REPOMD)['origin']['location_href']                         
            koji.util.rmtree(tmpdir)                                                                          
…
        relpath = os.path.join(repodir, self.br_arch, pkgorigins)                                             
        with koji.openRemoteFile(relpath, **opts) as fo: