koji

Clone

#1391 remove duplicated tags in maven_tag_archives
Closed 5 years ago by tkopecek. Opened 5 years ago by tkopecek.
tkopecek/koji maven_inheritance  into  master

file modified
+2 -2 
@@ -2262,9 +2262,9 @@ 
 

      of a given groupId:artifactId, not just the most-recently-tagged.
 

      """
 

      packages = readPackageList(tagID=tag_id, event=event_id, inherit=True)
 

-     taglist = [tag_id]
 

+     taglist = set([tag_id])
 

      if inherit:
 

-         taglist.extend([link['parent_id'] for link in readFullInheritance(tag_id, event_id)])
 

+         taglist |= set([link['parent_id'] for link in readFullInheritance(tag_id, event_id)])
 

      fields = [('tag.id', 'tag_id'), ('tag.name', 'tag_name'),
 

                ('build.pkg_id', 'pkg_id'), ('build.id', 'build_id'),
 

                ('package.name', 'build_name'), ('build.version', 'build_version'),

Some weird inheritance structure can add duplicate tags here.

The order of tags returned by readFullInheritance matters here. We cannot throw it away.

Edited 5 years ago by mikem

I would like to see more information on the issue we're trying to fix here.

Oh, yes - I've tested it more and it doesn't help much - most of time is still spent in symlinking. I'll drop this one.

Pull-Request has been closed by tkopecek
5 years ago
Changes Summary 1
+2 -2
file changed
hub/kojihub.py
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.