#1380 no notifications in case of deleted tag
Merged 2 years ago by tkopecek. Opened 3 years ago by tkopecek.
tkopecek/koji issue1379  into  master

file modified
+6 -4
@@ -7523,12 +7523,14 @@ 

          return None

      if tag_id:

          tag = get_tag(tag_id)

-         for email in get_notification_recipients(build, tag['id'], state):

-             recipients[email] = 1

+         if tag:

+             for email in get_notification_recipients(build, tag['id'], state):

+                 recipients[email] = 1

      if from_id:

          from_tag = get_tag(from_id)

-         for email in get_notification_recipients(build, from_tag['id'], state):

-             recipients[email] = 1

+         if from_tag:

+             for email in get_notification_recipients(build, from_tag['id'], state):

+                 recipients[email] = 1

      recipients_uniq = to_list(recipients.keys())

      if len(recipients_uniq) > 0 and not (is_successful and ignore_success):

          task_id = make_task('tagNotification', [recipients_uniq, is_successful, tag_id, from_id, build_id, user_id, ignore_success, failure_msg])

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

2 years ago

Commit 9ac3fa7 fixes this pull-request

Pull-Request has been merged by tkopecek

2 years ago

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done

2 years ago