#137 do not bind mount for image builds
Closed 7 years ago by mikem. Opened 7 years ago by ausil.
Unknown source no-dev-bind  into  master

No commits found

mock makes its own loop device nodes in its fake /dev/
we no longer need /dev/ bind mounted and it appears to
be causing issues with livemedia. bind mounting /selinux
was never a good idea

Signed-off-by: Dennis Gilmore dennis@ausil.us

A bug +1 for this. It appears to fix the nightmare https://bugzilla.redhat.com/show_bug.cgi?id=1315541 we've been struggling with for months: we're running the Fedora-25-20160822.n.1 compose with this and for the first time since switching to pungi4 / livemedia-creator , we have live image composes where anaconda doesn't crash and none of them appears to be hitting the bug where the install root cannot be properly umounted.

Both live (LiveMediaTask) and appliance (ApplianceTask) images seem to be composing successfully.

actually it seems like this may be causing issues for ApplianceTask tasks, according to Dennis; if so, we should be able to restore the bind mount for that class while leaving it out of the LiveMediaTask class.

I am concerned about this. It changes behavior with no way for someone to get the original behavior.

I guess that may be less of an issue if we move adjust things so that this only affects createLiveMedia tasks.

https://pagure.io/koji/pull-request/138 is my alternative which should only change LiveMediaTask (and makes this more flexible in general). From dgilmore and nirik's chat on IRC I think what's happening with appliance-creator tasks is some of them - the larger ones - are hanging the builders, similarly to https://bugzilla.redhat.com/show_bug.cgi?id=1368743 .

Pull-Request has been closed by mikem

7 years ago
Metadata