PR#1327: volume option for dist-repo - koji

koji

#1327 volume option for dist-repo

Merged 4 years ago by mikem. Opened 5 years ago by mikem.

mikem/koji dist-repo-volume into master

No commits found

When the rpms live on a different volume, it's very inefficient to generate a dist repo on the main volume (because rpms will have to be copied instead of linked). This change allows the user to specify the volume for the repo.

Fixes: #1366

mikem commented 5 years ago

Now that I'm filing this, I realize that I need to update kojira as well...

5 new commits added

fix unit test
handle other volumes in pruneLocalRepos
kojira: handle repos on other volumes
also write repo.json for normal repos
write repo.json in dist_repo_init

5 years ago

ngompa commented 5 years ago

:thumbsup:

1 new commit added

fix

5 years ago

ngompa commented 5 years ago

@mikem Please make sure to clean up the commits before merging it. Commits that just say fix don't help anyone later down the road...

mikem commented 5 years ago

@ngompa In this project, PRs are the unit of change and we have an always merge policy. Anyone looking at commits needs to consider them in the context of the PR they are contained in.

mikem commented 5 years ago

That said, of course it is better to have clear commit messages (and I usually do).

ngompa commented 5 years ago

@mikem I'm aware of that, but I was trying to figure out what the specific change that came from fix was for. Normally, the commits going in do actually make sense, so I don't have to say anything.

rebased onto 0f2fc87

5 years ago