#1292 define _sortByKeyFuncNoneGreatest as staticmethod
Merged 5 years ago by mikem. Opened 5 years ago by tkopecek.
tkopecek/koji issue1291  into  master

file modified
+2 -1
@@ -11052,6 +11052,7 @@ 

          else:

              return 1

  

+     @staticmethod

      def _sortByKeyFuncNoneGreatest(key):

          """Return a function to sort a list of maps by the given key.

          None will sort higher than all other values (instead of lower).
@@ -11121,7 +11122,7 @@ 

              else:

                  reverse = False

              if filterOpts.get('noneGreatest', True):

-                 results.sort(self._sortByKeyFuncNoneGreatest(order), reverse=reverse)

+                 results.sort(key=self._sortByKeyFuncNoneGreatest(order), reverse=reverse)

              else:

                  results.sort(key=order, reverse=reverse)

  

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

5 years ago

2 new commits added

  • convert xmlrpc.Binary to string before fixEncoding
  • expect string keys in fixEncodingRecurse
5 years ago

1 new commit added

  • define _sortByKeyFuncNoneGreatest as staticmethod
5 years ago

Commit cb6e42b fixes this pull-request

Pull-Request has been merged by mikem

5 years ago