PR#1180: Update source when recycling build - koji

koji

#1180 Update source when recycling build

Merged 5 years ago by mikem. Opened 5 years ago by mizdebsk.

mizdebsk/koji recycle-source into master

Update source when recycling build

Mikolaj Izdebski • 5 years ago

80f4231

hub/kojihub.py

file modified

+1 -1

		`@@ -5179,7 +5179,7 @@`

		`data['id'] = old['id']`
		`update = UpdateProcessor('build', clauses=['id=%(id)s'], values=data)`
		`- update.set(**dslice(data, ['state', 'task_id', 'owner', 'start_time', 'completion_time', 'epoch']))`
		`+ update.set(**dslice(data, ['state', 'task_id', 'owner', 'start_time', 'completion_time', 'epoch', 'source']))`
tkopecek commented 5 years ago 'extra' needs to be there also
		`update.rawset(create_event='get_event()')`
		`update.execute()`
		`builddir = koji.pathinfo.build(data)`

mizdebsk commented 5 years ago

Fixes: #1179

tkopecek commented on line 6 of hub/kojihub.py 5 years ago

'extra' needs to be there also

mikem commented 5 years ago

'extra' needs to be there also

'volume_id' too

mikem commented 5 years ago

https://pagure.io/fork/mikem/koji/commits/pagure/pr/1180

mikem commented 5 years ago

If that looks good, I'll go ahead and merge

mizdebsk commented 5 years ago

Resetting 'volume_id' and 'extra' looks reasonable - with this change all fields of build are updated (except pkg_id, version and release, which form a unique key and must not change for recycled build).

mikem commented 5 years ago

Commit 06953ff fixes this pull-request