PR#1149: hub: new addArchiveType RPC - koji

koji

#1149 hub: new addArchiveType RPC

Merged 4 years ago by tkopecek. Opened 5 years ago by ktdreyer.

ktdreyer/koji add-archive-type into master

No commits found

Add a new hub method for inserting new archivetype records.

This closely matches addBType.

The purpose of this change is to make it easier to permit content generators to import files with extensions that we have not defined in the upstream packaged koji SQL file.

julian8628 commented 5 years ago

This might also require duplicate checking for 'extensions'

rebased onto 0daa145a2d0b8bd8ff50a3111be705f551eb7bb3

5 years ago

ktdreyer commented 5 years ago

Thanks @julian8628 . I've added checks for duplicate extensions.

ngompa commented 5 years ago

@ktdreyer One test failure:

======================================================================
ERROR: test_add_archive_type (tests.test_hub.test_add_archivetype.TestAddArchiveType)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/srv/jenkins/workspace/koji/label/F26/kojienv/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "/srv/jenkins/workspace/koji/label/F26/tests/test_hub/test_add_archivetype.py", line 29, in test_add_archive_type
    kojihub.add_archive_type('deb', 'Debian package', 'deb')
  File "/srv/jenkins/workspace/koji/label/F26/hub/kojihub.py", line 6241, in add_archive_type
    results = _multiRow(select, {}, ('id',))
  File "/srv/jenkins/workspace/koji/label/F26/hub/kojihub.py", line 4568, in _multiRow
    return [dict(zip(fields, row)) for row in _fetchMulti(query, values)]
  File "/srv/jenkins/workspace/koji/label/F26/hub/kojihub.py", line 4539, in _fetchMulti
    c = context.cnx.cursor()
  File "/srv/jenkins/workspace/koji/label/F26/koji/context.py", line 46, in __getattr__
    return object.__getattribute__(data, key)
AttributeError: '_data' object has no attribute 'cnx'

ktdreyer commented 5 years ago

The tests pass for me on Fedora 29... Koji developers, any clue what I've done wrong?