PR#1064: Don't try to delete missing paths - koji

koji

#1064 Don't try to delete missing paths

Closed 3 years ago by tkopecek. Opened 5 years ago by tkopecek.

tkopecek/koji issue1063 into master

Don't try to delete missing paths

Tomas Kopecek • 5 years ago

7fdd00b

util/kojira

file modified

+1 -1

		`@@ -160,7 +160,7 @@`
		`# No such file or directory, so the repo either never existed,`
		`# or has already been deleted, so allow it to be marked deleted.`
		`self.logger.info("Repo directory does not exist: %s" % path)`
		`- pass`
		`+ return True`
		`else:`
		`self.logger.error("Can't stat repo directory: %s, %s" % (path, e.strerror))`
		`return False`

tkopecek commented 5 years ago

Fixes: https://pagure.io/koji/issue/1063

mikem commented 5 years ago

By returning at this point, you skip the part where kojira marks the repo as deleted in the db. This avoids the cosmetic error, but will result in the entry persisting forever. So, kojira will run this code for such repos repeatedly and without end.

mikem commented 5 years ago

Also see comments on #1063

pretty please pagure-ci rebuild

4 years ago

Pull-Request has been closed by tkopecek

3 years ago