PR #940

does it make sense to also add --not-ready --disabled?

The option naming seems a little odd to me. The command is list-channels, so the default expectation is that options would be about channels, not hosts. I wonder if it would be clearer as --host-enabled and --host-ready or similar. Perhaps I'm being pedantic...

Also, it seems that this is getting beyond just listing channels and into displaying the host_channels mapping. Calculating a quick total didn't seem like much of a perturbation, but if we're going to start filtering hosts, then we may also want:

• more host selection options: arch, name pattern, maybe other in the future
• an option to list out the full selected mapping (e.g. host names, not the total)
• maybe listing total capacity a channel
• maybe listing tasks by channel

I don't know how much sense it makes to cram to much functionality into this command.

Conversely, I wonder if it would be better to add a --by-channel option to list-hosts.

Maybe it would help to state what problem we're trying to solve here.

My guess at motivation is to give admins a better view of channel capacity. If that is the goal, we might want to do more than this.

I know I'm inflating this a lot.

I suppose one could argue that it's misleading to show host totals that include disabled hosts. Perhaps instead of these options, we should just show more data all the time. E.g.

$ koji list-channels
Channel         Enabled    Ready   Disabled
default               4        2          2
createrepo            1        0          0
image                 1        1          0

We can easily get those totals from the data in listHosts(channelID=channel['id'])

I originally intended to do exactly this (table), but stripped it to least-invading change. But yes, I'm for this, as it gives much better overview of cluster health. (Going to fix the PR)

Commit f3b4af0 fixes this issue

Commit 77237cb fixes this issue