#913 hub uses absolute symlinks for imported work files
Closed: Fixed 5 years ago Opened 5 years ago by mikem.

When the hub moves task files into place, it normally replaces the original upload location with a symlink. This is done mainly so that the files still appear on the task page after a build is imported.

However, the hub is using absolute symlinks to do this. This doesn't necessarily cause a problem, but it could if:

  • the topdir location changes on the hub
  • a client is using a different topdir setting than the hub

There are several places we do something like this:

safer_move(fn, dest)
os.symlink(dest, fn)

I think it would be worth wrapping this up in a function (e.g. move_and_symlink), and using os.path.relpath to calculate the symlink target.

Metadata Update from @mikem:
- Issue tagged with: easyfix

5 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #920 Merged 5 years ago