#725 'postBuildStateChange' doesn't always contain consistent buildinfo
Closed: Fixed 3 years ago Opened 3 years ago by julian8628.

The full buildinfo(with package_name,owner_name, etc) is obtained by get_build().
But in some places the buildinfo is assembled when creating, and then directly passed to callbacks.
In this case, some plugins like messagebus won't get the useful information like owner_name for instance.

After looking inside the code, I found here we might meet another problem that the buildinfo passed to preBuildStateChange and postBuildStateChange should be reconsidered.
Should it be a completely new information reflecting the build after the change?


Metadata Update from @tkopecek:
- Issue set to the milestone: 1.16

3 years ago

Have we encountered actual issues with this, or is this something you noticed in the code?

Have we encountered actual issues with this, or is this something you noticed in the code?

The first one was filed by Brew user. He wants to get owner_name in CG build via UMB messages.

and the second one

After looking inside the code, I found here we might meet another problem that the buildinfo passed to preBuildStateChange and postBuildStateChange should be reconsidered.
Should it be a completely new information reflecting the build after the change?

is what I found in the code.

Commit 2b7b90a relates to this ticket

Commit 7c1865f relates to this ticket

Oops, that merge was supposed to close this

Metadata Update from @mikem:
- Issue status updated to: Closed (was: Open)

3 years ago

Metadata Update from @mikem:
- Issue close_status updated to: Fixed

3 years ago

Login to comment on this ticket.

Metadata