repos/dist/ creates a potential name collision. Why is repos-dist more awkward than dist-repos? Why is repos-dist awkward at all?

The subdirectory is not an option. It's a namespace issue.

If folks feel strongly about this, we can look into renaming the directory for 1.13, but note this is now effectively an API change. The reasons for changing this are cosmetic, but the impact of changing it is definitely not.

repos-dist vs dist-repos convey different things to me. The former conveys that it's a type of repo, since we have repos already. I'm okay with repos-dist.

dist-repos to me reflects distribution repos which is the intent, its a natural flow it also matches the name of the feature.a repos-dist rolls off the tongue awkwardly, and does not seem to reflect anything. I do not see it as a api change, I do not feel overly strongly about it. I feel that we can fix it quickly before it has adoption, I think that 1.13 is too late and it should come in a 1.12.1 with a statement we should have had it as such from day 1.

Changing this will result in an incompatibility that will have to be dealt with. Upgrading from 1.12 to 1.12.1 should not require admins to rearrange /mnt/koji any more than it should require a schema change.

Again, not saying whether we should or should not, but it is not trivial and it would have to be 1.13. Given that this is aethetic, and changing it is potentially tricky, I would like have the reasoning very well laid out if we are going to change it.

I personally don't think repos-dist is awkward, or at least not awkward enough to worry about. We append rather than prepend qualifiers in software (and other human language) all the time.

Advantages for repos-dist:

• no changes required
• sorts after repos in directory listings
• "repos" is arguably the key word here

Advantages for dist-repos:

• matches the word order of the command name
• possibly less awkward to some people

Does anyone else want to weigh in? Without some sort of consensus on the "awkwardness" I'm not inclined to spend more time on this.

I'm honestly confused that you find /mnt/koji/repos/dist/ ok, but /mnt/koji/repos-dist/ awkward.

I'm honestly confused that you find /mnt/koji/repos/dist/ ok, but /mnt/koji/repos-dist/ awkward.

its still awkward, just less so. Being a directory it is clear that it is repos for distribution. The issue was more for trying to make sure we take a bit more care. I think that the last minute renaming helped add to the confusion here. I had honestly not noticed before it landed.

Given that it's cosmetic and a non-trivial change, my suggestion would be to leave it as-is and use that development time on other items in the backlog.

I'm going to leave this as is. Add a dist-repos symlink if you like