#3434 parse_arch should support list of arches
Closed: Fixed 2 years ago by tkopecek. Opened 2 years ago by jcupova.

Currently, parse_arch support only string arches. We want to extend parse_arch to list of arches also.


Metadata Update from @jcupova:
- Custom field Size adjusted to None

2 years ago

Metadata Update from @tkopecek:
- Issue tagged with: testing-ready

2 years ago

Can you indicate the motivation here? You write "we want to", but you don't give a reason.

The verb "parse" typically implies acting on a string, so this could be something of a surprising polymorphism. PR does not include any changes that utilize this new behavior.

It appears this function has a somewhat muddied purpose. It was originally meant to normalize a list of arches for storage in a string field in the db (returning a space separated list). However, because it also applies a simple regex check on the arches, it looks like we also use it to validate single arches a few places.

Ah, I found issue why we create this new issue :-). So, first problem was this issue https://pagure.io/koji/issue/3427 where I fixed it by easy way, because the issue was for minor milestone. And after discuss with @tkopecek that we created this issue for major release. And when I see it, I need to add revert change for issue 3427, that it can use new parse_arches :-). I'll do it tomorrow :-)

Metadata Update from @relias-redhat:
- Issue tagged with: testing-done

2 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #3440 Merged 2 years ago