Learn more about these different git repos.
Other Git URLs
Nothing uses koji.listFaults(). I searched all of GitHub and found no references to 3rd-party code either.
koji.listFaults()
Let's remove this method from the tree.
Looking through the git history, it appeared in the initial code drop, and nothing has ever called this method.
Metadata Update from @tkopecek: - Custom field Size adjusted to None - Issue set to the milestone: 1.27 - Issue tagged with: deprecation
@mikem any concerns with directly dropping this? (or rather deprecation warning?)
Well, anything in the main lib needs to have a deprecation period.
My only concern is that we might want something like this functionality (but probably not this implementation) in the future. It's currently tricky to add new faults because an older client will not know about them. It might be nice if they were discoverable.
PR #3082
Metadata Update from @julian8628: - Issue tagged with: testing-ready
Metadata Update from @jobrauer: - Issue tagged with: testing-done
Commit 537439c fixes this issue
Commit 9e6be3f relates to this ticket
Log in to comment on this ticket.