#2865 cg_import silently ignores non-existent content
Closed: Fixed 2 years ago by tkopecek. Opened 2 years ago by tkopecek.

match_rpm currently raises error on external rpms thus anything passing this test should exist. Anyway, we're just putting warning to log and not putting it anywhere where user can see it. It is a long-time TODO to properly handle external rpms, but maybe there is a simpler way - add special import log artifact to logs section?


Metadata Update from @tkopecek:
- Custom field Size adjusted to None

2 years ago

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.27 (was: 1.26)

2 years ago

I think the issue is that content generators have never been as well behaved as we would like them to be.

Metadata Update from @tkopecek:
- Issue close_status updated to: Dropped
- Issue status updated to: Closed (was: Open)

2 years ago

Metadata Update from @tkopecek:
- Issue set to the milestone: None (was: 1.27)

2 years ago

I'm cautious about modifying things at import time. Adding a log that isn't in the metadata seems inconsistent. OTOH, some sort of import log makes kind of makes sense.

Maybe we could store the error somewhere a bit more separate? Perhaps under data/import? Or even just in the root build directory alongside metadata.json?

Metadata Update from @mikem:
- Issue set to the milestone: 1.27

2 years ago

Just to clarify, the description seems to be proposing making the errors more visibly logged rather than, say, blocking the import. Correct?

Yes, just making it more visible. Putting it alongside metadata.json looks good to me.

Metadata Update from @tkopecek:
- Issue status updated to: Open (was: Closed)

2 years ago

Ok, let's go this way (removing discussion tag, planning it of next release)

Metadata Update from @tkopecek:
- Issue untagged with: discussion
- Issue set to the milestone: 1.28 (was: 1.27)

2 years ago

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.29 (was: 1.28)

2 years ago

Metadata Update from @jcupova:
- Issue tagged with: testing-ready

2 years ago

Metadata Update from @jobrauer:
- Issue tagged with: testing-done

2 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #3257 Merged 2 years ago