Issue #2719: Error for download-build and non-existing sigkey should be improved - koji

koji

#2719 Error for download-build and non-existing sigkey should be improved

Closed: Fixed 2 years ago by tkopecek. Opened 3 years ago by mfilip.

Something like "no such key xxxx" would be better.

koji download-build --key=key-x1b2 kojitest-dummyrpm-i4t3d-1.1-11

2021-02-23 01:04:53,853 [ERROR] koji: HTTPError: 404 Client Error: Not Found for url: http://10.0.105.207/kojifiles/packages/kojitest-dummyrpm-i4t3d/1.1/11/data/signed/key-x1b2/src/kojitest-dummyrpm-i4t3d-1.1-11.src.rpm

ktdreyer commented 3 years ago

IMHO it would be nice to keep the 404 error code and URL in the output, though.

tkopecek commented 3 years ago

It is two separate issues to be checked here. We could/should look to db if signed rpm exists and then raise 404 if it is not found on download server.

Metadata Update from @tkopecek:
- Custom field Size adjusted to None

3 years ago

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.26

3 years ago

ktdreyer commented 3 years ago

Yeah, that's a good idea. Files can be "signed" but there is a small race when the fully signed RPMs are still being written out to disk.