Learn more about these different git repos.
Other Git URLs
As reported on koji-devel (Subject "Error: "<type 'exceptions.TypeError'>: object of type 'NoneType' has no len()"> in koji"), the hub's host.completeBuild RPC can crash in some cases.
host.completeBuild
The problem is that 6ae165f changed get_notification_recipients() to return None in specific circumstances. When we call len() on None in build_notification(), we get a TypeError.
get_notification_recipients()
None
len()
build_notification()
TypeError
To fix this, we should make get_notification_recipients() return an empty list instead of None.
(Additionally, we should simplify that if len(recipients) > 0: conditional in build_notification() to just simply if recipients: so that is easier to read.)
if len(recipients) > 0:
if recipients:
PR #2308 fixes this bug.
PR #2309 cleans up the conditional in build_notification() to make the code easier to read.
Metadata Update from @mikem: - Custom field Size adjusted to None - Issue set to the milestone: 1.22
Metadata Update from @mikem: - Custom field Size adjusted to small (was: None)
Commit eb8d7f9 fixes this issue
Commit 4fb79b9 fixes this issue
Metadata Update from @jcupova: - Issue tagged with: testing-ready
Metadata Update from @mfilip: - Issue tagged with: testing-done
Login to comment on this ticket.