#2251 Improve volume policy to work with content generators
Closed: Fixed 3 years ago by tkopecek. Opened 3 years ago by tkopecek.

Wa want additional test for volume policy to detect CG, so policy can work with that. It an be done in clumsy way even today, but clean test would help


Metadata Update from @tkopecek:
- Custom field Size adjusted to None

3 years ago

Metadata Update from @tkopecek:
- Issue tagged with: testing-ready

3 years ago

Metadata Update from @mfilip:
- Issue tagged with: testing-done

3 years ago

Note that we already had cg tests in the policy. The limitation was that the policy only had data about cgs during a CGImport call. The above PR extends this by examining data from a build value provided to the policy -- meaning that many more policy events would see that cg data, e.g. a call to applyVolumePolicy (or for that matter tagging policies).

EDITED: policy_get_cgs also checks buildroot data and has since 2016. If that part of the code isn't working, we should fix it.

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.24 (was: 1.23)

3 years ago

Metadata Update from @jcupova:
- Issue untagged with: testing-done, testing-ready

3 years ago

After reviewing #2496 again, I'm not sure what is wrong with the existing code. All cg imports, old and new, should have cg info in their buildroot data, and all cg imports should have buildroot data. The existing policy check looks at that buildroot data. I don't quite recall the details of the situation that led to this issue getting filed, but I think we ought to try to demonstrate an example of the behavior we want to change.

Metadata Update from @tkopecek:
- Issue set to the milestone: None (was: 1.24)

3 years ago

Metadata Update from @tkopecek:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

3 years ago

Other changes meanwhile fixed most (if not all the issues). Let's close this one for now and open a new one in case there will be some new problematic situation.

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #2496 Closed 3 years ago