#2221 download_rpm can fail with some sigmd5s
Closed: Fixed 3 years ago by tkopecek. Opened 3 years ago by tkopecek.

Some rpms use different headers, see comments in kojihub / add_rpm_sig Checking function in CLI can now refuse to download such rpm.


Metadata Update from @tkopecek:
- Custom field Size adjusted to None

3 years ago

Metadata Update from @jcupova:
- Issue tagged with: testing-ready

3 years ago

The example failure that was given to me involved the sigmd5 value getting mangled because the original bytes value had been decoded to a string, and then encoded as a hex string. In some cases the binary sum would break that fragile process. The problem is I think when the binary md5 manages to be valid unicode and include multibyte characters.

In the case I was given, the md5 was: 26007b694b41392d76122e05c289dc8c

This decodes as: '&\x00{iKA9-v\x12.\x05\x89܌'

That last two characters are multibyte and hex_string gets this wrong because it is iterating over the characters of the string.

#2268 addresses the latter issue. If there are other examples that fail for different reasons, please bring them up.

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.21.1 (was: 1.22)

3 years ago

'testing-ready' tag was removed for testing purposes, will be reverted soon

Metadata Update from @mfilip:
- Issue untagged with: testing-ready

3 years ago

Metadata Update from @mfilip:
- Issue tagged with: testing-ready

3 years ago

Metadata Update from @jcupova:
- Issue tagged with: testing-done

3 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #2268 Merged 3 years ago
  • #2222 Closed 3 years ago