#2196 packaging: use %autosetup to manage patches
Closed: Fixed 3 years ago by tkopecek. Opened 3 years ago by alexi.

Can we use %autosetup in the %prep section of the specfile to manage patches? It will save a bit of effort for those of us that maintain our own patches.


Metadata Update from @mikem:
- Custom field Size adjusted to None
- Issue priority set to: Low (was: Normal)
- Issue tagged with: discussion

3 years ago

I'm not necessarily opposed, however...

  • the spec that we ship will never include patches. We leave that to individual packagers.
  • packagers are going to have to modify the spec anyway if they need to patch
  • I want to make sure this isn't going to break other packagers' processes

So let's leave this open for discussion for a while. I don't see any reason to rush to apply this change upstream.

One of the reasons I pushed %autosetup to ceph upstream was that it makes the diff smaller between upstream and downstream. I agree it's not immediately intuitive because we will never carry patches upstream, but here are the reasons I think we should take this change:

1) It makes it easier for humans to visually inspect diffs between upstream and downstream.

2) It makes it easier for people to patch/build/distribute Koji quickly.

Yes, this is exactly why I wanted to push this upstream. We patch our build and having this change upstream is a noop for the upstream build, but will make our diff smaller and easier to maintain. Yeah, it's not a huge difference, but it's the little things... :)

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.22

3 years ago

Metadata Update from @tkopecek:
- Issue untagged with: discussion

3 years ago

Metadata Update from @jcupova:
- Issue tagged with: no_qe

3 years ago

Login to comment on this ticket.

Metadata