Learn more about these different git repos.
Other Git URLs
Feel free to close this issue if this is improper way, but I wanted to warn koji maintainers that there are some changes in mock that may affect the build behavior in koji. Namely:
The dnf_warning option. That one newly needs to be set in Koji, unless you will turn bootstrap_chroot on. This thing is going to warn that yum is missing on Koji's builders, unless yum.rpm really provides YUM (YUM from mock POV is not the same as /bin/yum symlink to dnf).
dnf_warning
bootstrap_chroot
yum
yum.rpm
We turned the bootstrap_chroot on by default. This should be disabled in Koji explicitly if desired.
We started using dnf.conf instead of yum.conf config option for DNF chroots by default, but if yum.conf is set (and only that) mock still keeps using yum.conf. From Koji perspective this should be fine, as koji has its own configuration (not using mock-core-configs). Edit: The yum.conf/dnf.conf will be solved anyways in mock v2.1 (will be release soon), where both options will be aliases to each other.
dnf.conf
yum.conf
@kdudka fyi, this will affect covscan as well
Another hint. The package_manager default was changed from yum to dnf. This means that e.g. epel-7 configs need to have package_manager = yum (and fedora configs can drop the package_manager = dnf).
package_manager
dnf
epel-7
package_manager = yum
package_manager = dnf
HUm, so I guess my question is:
What needs to be changed to keep things the way they are now?
Note that koji sets some mock options in tag info:
Tag options: mock.new_chroot : 0 mock.package_manager : 'dnf'
So, koji might need to also add 'bootstrap_chroot' and 'dnf warning' for those?
Metadata Update from @kevin: - Custom field Size adjusted to None
What needs to be changed to keep things the way they are now? .. So, koji might need to also add 'bootstrap_chroot' and 'dnf warning' for those?
Yes, mock.bootstrap_chroot: False (all), and dnf_warning: False (for yum-based chroots).
mock.bootstrap_chroot: False
dnf_warning: False
@praiskup Thank you for letting me know. I updated Covscan to mock-2.1 today and it seems to work fine so far. Good job!
mock-2.1
It should probably just always set mock.package_manager, as it doesn't hurt to make the value always be set.
mock.package_manager
So, we just hit this and it broke things for us... (because I didn't realize 2.1 was in f31 stable now).
So, summary I guess:
new_chroot -> koji needs to change here because it passes mock --new-chroot or --old-chroot, and in mock 2.x this is --isolation=simple or --isolation=nspawn package_manager -> need to set in all the old tags where yum was default (this is on installs, not koji I guess, unless koji wants to default to yum?) bootstrap_chroot -> add to koji, or can be set in site_defaults on per install. dnf_warning -> perhaps koji could just always supress this?
Metadata Update from @tkopecek: - Issue set to the milestone: 1.22
new_chroot -> koji needs to change here because it passes mock --new-chroot or --old-chroot, and in mock 2.x this is --isolation=simple or --isolation=nspawn
That should be just warning, --old/new-chroot is still supported.
bootstrap_chroot -> add to koji, or can be set in site_defaults on per install.
Yes, but be aware of #1988.
Otherwise I agree.
@kevin So, for 1.22 we need only to set dnf_warning=False by default? Because now we force it to True in all cases (#1595).
dnf_warning=False
True
Yes, thats the minimal change needed. We set it in site_defaults.cfg for mock.
bootstrap_chroot False might also be wise... as it makes the builders take up more disk space with bootstrap chroots and is (or so I have been told) slower...
I've turned off dnf_warning in #2353 as it is hardcoded in koji. For bootstrap I would prefer setting it per tag as it is working the same way as other mock settings. If it is set in tag's extra, that value is used if not, mock's defaults are used. #1968. #2212 also added automatic boostrap cleanup, so it shouldn't leave garbage from 1.22.
Metadata Update from @jcupova: - Issue tagged with: testing-ready
Metadata Update from @jcupova: - Issue tagged with: testing-done
Commit ea1b7a6 relates to this ticket
Commit 72c7012 relates to this ticket
Closing this since #2353 is merged. The other options are controlled via tag extra settings.
Metadata Update from @mikem: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.