#1926 koji-gc always does delete, prune, trash
Closed: Invalid 4 years ago by kevin. Opened 4 years ago by kevin.

We have 3 cron jobs that call koji-gc:

koji-gc --action=delete
koji-gc --action=trash
koji-gc --action=prune

Unfortunately, all 3 of them output:

"Getting list of builds in trash..."

which is the output of the 'delete' action.

It looks like perhaps 24a547a didn't change the default actions, it changed the passed in action to always start with 'delete' and since it only does one...

EDITED: ah, it looks like each job is doing all 3 actions, not just delete.


It is in 1.19.1? All three actions work correctly for me there.

Metadata Update from @tkopecek:
- Custom field Size adjusted to None

4 years ago

Hum, it's to do with how we are calling them.

We use a script called 'lock-wrapper' https://infrastructure.fedoraproject.org/cgit/ansible.git/tree/roles/base/files/common-scripts/lock-wrapper

ie,

lock-wrapper somejobname /usr/sbin/koji-gc --action prune

If I call them directly they work fine, so it's something to do with the wrapping script somehow.

@kevin Script is ignoring additional options. It uses just $1 and $2, while $2 is what is executed in the end. So anything after 'koji-gc' is ignored.

Yep, so it is. ;(

I fixed the wrapper... we can close this now. Sorry for the noise...

Metadata Update from @kevin:
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)

4 years ago

Login to comment on this ticket.

Metadata