#1729 koji CLI still checks for admin permission instead of tag/target/host
Closed: Fixed 2 years ago by tkopecek. Opened 2 years ago by cobrien.

PR #1454 introduced new permissions that gate hub calls for working with tags, targets, and hosts.

However, the koji CLI still marks the CLI commands that trigger those hub calls as admin commands, and the command handlers check for the admin permission before even attempting to make the hub call.

Thus for example, a user with the tag permission will receive the error
"This action requires admin privileges" when running koji add-tag foo-bar-baz

But can successfully run koji call createTag foo-bar-baz


Metadata Update from @tkopecek:
- Custom field Size adjusted to small
- Issue set to the milestone: 1.20
- Issue tagged with: bug

2 years ago

Submitted PR https://pagure.io/koji/pull-request/1730 against the 1.18 updates branch

This couldn't make it into 1.19? That's why I rushed to get the fix PR created... the major permissions feature from 1.18 is effectively non-existent without the fix in place.

Sorry, it appeared after code-freeze. But we can backport it for you internally.

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.19.1 (was: 1.20)

2 years ago

Metadata Update from @jcupova:
- Issue tagged with: testing-done

2 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #1733 Merged 2 years ago
  • #1730 Closed 2 years ago