koji

Clone

#1472 prePackageListChange shouldn't be called if change will not happen
Closed: Fixed 2 years ago by tkopecek. Opened 4 years ago by tkopecek.

Closed: Fixed
Reopen Issue

There is no action made in _direct_pkglist_add, if there are no changes and force is not specified. In such case prePackageListChange callback is emitted, but not post-one. So, there are two problems - a) inconsistent pre/post sequence and b) it doesn't make sense to call 'pre' part anyway.

PR 3403

Metadata Update from @jcupova:
- Custom field Size adjusted to None
2 years ago

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.30
2 years ago

Metadata Update from @tkopecek:
- Issue tagged with: testing-ready
2 years ago

Metadata Update from @mfilip:
- Issue tagged with: testing-done
2 years ago

Commit c1643da fixes this issue

Commit f31d92d fixes this issue

Login to comment on this ticket.

Metadata
None

bug testing-ready testing-done

None
None
Normal
None
Related Pull Requests
  • #3403 Merged 2 years ago
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.