Learn more about these different git repos.
Other Git URLs
A minor thing... koji/daemon.py has a check to ensure that there is exactly one .spec file in the sourcedir
It would be slightly nicer if it did this check after "make sources" has been run, rather than before, in case "make sources" wants to construct the .spec file out of parts.
This is easy to work around, so it's really a cosmetic thing.
It is not that easy, but not much harder. Problem is, that build_srpm method is called already with spec_file and source_cmd. So in this case, spec_fle should be determined after source_cmd. It would be a problem in WrapperRPMTask, where spec doesn't exist and is created on fly from template. We possible can have spec_file=None which means, that spec file filename and spec_sanity_checks can be run after that inside build_srpm.
build_srpm
spec_file
source_cmd
WrapperRPMTask
spec_file=None
spec_sanity_checks
@mikem any concerns?
Alternatively, you can keep the requirement that the correct specfile name be passed to build_srpm but run source_cmd before making the check that the expected specfile exists. Open Science Grid has a patch for doing that, but it's for Koji 1.11; if people are interested, I can update it and make a PR.
Login to comment on this ticket.