#1240 admin_emails not working
Closed: Fixed 4 years ago by tkopecek. Opened 5 years ago by tkopecek.

I suspect, that admin_emails settings in kojid.conf doesn't work as expected. There is no conversion to list during config parsing, so it would create bogus e-mail addresses. (Not tested, but making a placeholder here)


Are you saying this has broken recently? I am currently getting admin emails from 1.16.1 based kojid instances.

The admin_emails option in kojid.conf is just a string. This is passed directly to add_mail_logger, which passes it directly to SMTPHandler, whose __init__ will wrap it in a list if it is a string. This is passed to smtp.sendmail.

Perhaps this will fail if there are multiple addresses separated by commas, but I wouldn't be surprised if it works as is, given the smtp protocol.

I don't think it is new, but just for correct passing multiple addresses I would add something like PR #1246. We're just relying on smtplib internal handling which can change without notice.

Metadata Update from @dgregor:
- Custom field Size adjusted to None
- Issue set to the milestone: 1.20

4 years ago

Metadata Update from @jcupova:
- Issue tagged with: testing-done

4 years ago

Metadata Update from @jcupova:
- Issue untagged with: testing-done
- Issue tagged with: testing-ready

4 years ago

Metadata Update from @jcupova:
- Issue tagged with: testing-done

4 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #1246 Merged 4 years ago