#1206 removeChannel behavior affected by host history feature
Closed: Fixed 2 years ago by tkopecek. Opened 5 years ago by mikem.

Since we now track historical host channel data (#778), a channel will have db references if it has ever been used (even if there are currently no hosts in the channel). These references prevent removal.

Furthermore, the force option to this call will happily delete historical entries from host_channels table. This is counter to the rest of Koji, which strictly avoids deleting history.

The only way this call can succeed without the force option is if the channel has never been used. However, there is no exposed way to add a new channel without also adding at least one host to it.


My inclination here is to simply deprecate this call, and the associated user command. It only made sense when we did not track historical channel data. However, I am open to argument.

Metadata Update from @mikem:
- Issue tagged with: deprecation, discussion

5 years ago

We could also make removeChannel simply remove all hosts from the channel (with history), but not actually remove the entry.

I suppose we could also add a way to hide channels, or a versioned way to delete channels.

Metadata Update from @mikem:
- Custom field Size adjusted to None

3 years ago

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.28

2 years ago

Now channels can be disabled which is more +1 to deprecate this call.

Metadata Update from @jcupova:
- Issue tagged with: testing-ready

2 years ago

Metadata Update from @ksulayma:
- Issue tagged with: testing-done

2 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #3158 Merged 2 years ago