#1007 decode_args() might result in --package parameter missing in runroot command
Closed: Fixed 3 years ago Opened 3 years ago by franzh.

The --package parameter is not passed into runroot and result in fails
e.g. koji runroot --package=lorax rhel-7.0-candidate x86_64 ...

Quote from Mike Bonnet's patch comments

The commit changes make_task() to call decode_args() on the arglist before it is saved to the db. If the method was called with keyword arguments, those would be passed in a dict at the end of the arglist, with a __starstar entry. decode_args() edits that dict in place, removing the __starstar entry and making the arglist appear to end in a single dict argument, effectively removing the keyword arguments. This change makes a copy of the dict before editing it, so no changes will be made to the arguments.


Metadata Update from @julian8628:
- Issue set to the milestone: 1.17

3 years ago

Metadata Update from @franzh:
- Issue set to the milestone: 1.16.1 (was: 1.17)

3 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #1008 Merged 3 years ago