From 9c92f5e4bee0180c778e7009a45f21136f0fb91f Mon Sep 17 00:00:00 2001 From: Tomas Kopecek Date: Aug 31 2020 06:54:33 +0000 Subject: PR#2457: hub: more verbose assertPerm error Merges #2457 https://pagure.io/koji/pull-request/2457 Fixes: #2429 https://pagure.io/koji/issue/2429 assertPerm() should show the username --- diff --git a/koji/auth.py b/koji/auth.py index ee42277..b8091cc 100644 --- a/koji/auth.py +++ b/koji/auth.py @@ -501,7 +501,12 @@ class Session(object): def assertPerm(self, name): if not self.hasPerm(name) and not self.hasPerm('admin'): - raise koji.ActionNotAllowed("%s permission required" % name) + msg = "%s permission required" % name + if self.logged_in: + msg += ' (logged in as %s)' % self.user_data['name'] + else: + msg += ' (user not logged in)' + raise koji.ActionNotAllowed(msg) def assertLogin(self): if not self.logged_in: