From 088ac36c06ad0565f5795e9d8f58b4a98cfa336f Mon Sep 17 00:00:00 2001 From: Franz Chih-Ping Hsieh Date: Aug 13 2018 20:53:57 +0000 Subject: PR#1008: decode_args(): make a copy of the opts dict, rather than modifying it in-place Merges #1008 https://pagure.io/koji/pull-request/1008 Fixes: #1007 https://pagure.io/koji/issue/1007 decode_args() might result in --package parameter missing in runroot command --- diff --git a/koji/__init__.py b/koji/__init__.py index 9d44488..f8156ae 100644 --- a/koji/__init__.py +++ b/koji/__init__.py @@ -439,8 +439,8 @@ def decode_args(*args): if len(args) > 0: last = args[-1] if isinstance(last, dict) and last.get('__starstar', False): - del last['__starstar'] - opts = last + opts = last.copy() + del opts['__starstar'] args = args[:-1] return args, opts