#53 koji-ssl-admin: fix the signature for cryptography.x509.*Builder().add_extension()
Merged 4 years ago by tkopecek. Opened 4 years ago by julian8628.
julian8628/koji-tools extension-fix  into  master

file modified
+2 -2
@@ -197,7 +197,7 @@ 

          x509.BasicConstraints(ca=True, path_length=0), critical=True,

      )

      builder = builder.add_extension(

-         extension=x509.KeyUsage(

+         x509.KeyUsage(

              digital_signature=True,

              key_encipherment=False,

              content_commitment=False,
@@ -260,7 +260,7 @@ 

      builder = builder.not_valid_before(datetime.utcnow())

      builder = builder.not_valid_after(in_two_years)

      builder = builder.add_extension(

-         extension=x509.KeyUsage(

+         x509.KeyUsage(

              digital_signature=True,

              key_encipherment=True,

              content_commitment=True,

The 1st argument has been changed from extension to extval.

Commit 8cb2204 fixes this pull-request

Pull-Request has been merged by tkopecek

4 years ago

Pull-Request has been merged by tkopecek

4 years ago
Metadata