#52 fedora_submit.py: handle being called the old way
Merged by jforbes. Opened by adamwill.
adamwill/kernel-tests accept-old-args  into  master

Download 52.patch

After a few folks tested this, I realized their results aren't
being submitted because they have existing .config files with
the old submit hook definition:

commithook="./fedora_submit.py $username $password -l $logfile"

which no longer matches how the script expects to be called.
Telling everyone to edit their config files is dumb, so let's
handle being called that way instead, but also print a warning
that people should edit the username and password out of their
config file for security.

Signed-off-by: Adam Williamson awilliam@redhat.com

if we want to keep things simple we can edit config.example to have the submit hook as ./fedora_submit.py -l $logfile and drop handling the fedora_submit.py $logfile style, at the cost of breaking things for anyone who happened to create their .config in the last couple of days, I guess.

That makes sense. Thanks for this.

Pull-Request has been merged by jforbes

Metadata