#16 bad compilation on kernel-tests / rpc.h
Closed: Fixed 2 years ago Opened 2 years ago by jcline.

From bugzilla:

The performance tests rely on rpc/rpc.h, which was removed from glibc in F28: https://fedoraproject.org/wiki/Changes/SunRPCRemoval. It's provided by libtirpc now.

To reproduce:

  1. git clone https://pagure.io/kernel-tests.git
  2. cd kernel-tests
  3. ./runtests.sh -t performance on F28+

Hi,

I’ve (kind of, very likely to break F27- though F28 is fine) fixed that here, if you’re willing to test:
https://pagure.io/kernel-tests/pull-request/18

HTH !

Without having a configure script determine where the Sun RPC library is, I'm not sure of a nice way to do this that will work with Fedora versions older than 28.

Now that I think a bit more about it, given that the diff is only

        $O/lib_sched.o

 lmbench: $(UTILS)
-       @env CFLAGS=-O MAKE="$(MAKE)" MAKEFLAGS="$(MAKEFLAGS)" CC="$(CC)" OS="$(OS)" ../scripts/build all
-       -@env CFLAGS=-O MAKE="$(MAKE)" MAKEFLAGS="-k $(MAKEFLAGS)" CC="$(CC)" OS="$(OS)" ../scripts/build opt
+       @env LDFLAGS="-ltirpc" CFLAGS="-O -I/usr/include/tirpc" MAKE="$(MAKE)" MAKEFLAGS="$(MAKEFLAGS)" CC="$(CC)" OS="$(OS)" ../scripts/build all
+       -@env LDFLAGS="-ltirpc" CFLAGS="-O -I/usr/include/tirpc" MAKE="$(MAKE)" MAKEFLAGS="-k $(MAKEFLAGS)" CC="$(CC)" OS="$(OS)" ../scripts/build opt

would you be ok with something as hacky as that ?

if [ -d /usr/include/tirpc ] (or any other check, /etc/fedora-release, installed rpc package…)
then
    #f28 def
else
    #f27- def
fi

At this point, the number of people testing kernels on F27 is fairly low, the number of them running tests outside of the default even lower. I am pulled the fix for F28, people running F27 or older can just checkout the previous version if needed.

Metadata Update from @jforbes:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

2 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #18 Merged a year ago