When building jss there are many deprecation warnings. Though many cannot be dealt with, and don't need to, at the present we should complete what has been started already and properly annotate the remaining ones. Adding the pertinent "@deprecation" and "@Deprecation" annotations with some comments will make the maintainers life easier in the future and is a fairly safe thing to do.
This is a spin-off of https://pagure.io/jss/issue/17 where it's sated that the effort should be done in two phases: 1) Add annotations the comments - no more than that and 2) Address to issues as the need arise in the future when things get removed. Filing this issue to concentrate on phase 1. Will do a pull request for the easy part.
See https://github.com/dogtagpki/jss/pull/23
Replaced by https://github.com/dogtagpki/jss/pull/26
Note to the reviewer: When testing you should build with 'export CHECK_DEPRECATION=1' which will result in many warnings as this is only annotations. Addressing the warnings is deferred to a later time. The warnings should only be ones regarding deprecations and no other ones.
Crude method I used to test, does same steps before and after the patch
<img alt="HowITestedThePullRequest" src="/jss/issue/raw/files/b408c666e707382d3168934a1f345e71df7da69436160928482c4dbb68a0682b-HowITestedThePullRequest" />
cd ~/jss <--- wrong, cit should be 'cd jss'
Alternative method I used to test.
<img alt="HowToTest.txt" src="/jss/issue/raw/files/107bb890b5d25161381b4590dc92d0715c0c59269e665210cdaf03caff0e6f72-HowToTest.txt" />
Analysis of the differences in the warnings before and after applying latest version of https://github.com/dogtagpki/jss/pull/26.
<img alt="changes-in-warnings" src="/jss/issue/raw/files/ebe72f5f831f453bdf0206557a29555495738c8981e24524f3a70e8efeed7881-changes-in-warnings" />
<img alt="changes-in-warnings" src="/jss/issue/raw/files/b8f3ea1efa749dc3f84a4ec160591586a3568dde6977802a8d0cf933b4ec65bb-changes-in-warnings" />
This is a new version of my testing procedure in the form of a shell strip. It produces a lot of files , specially diff's of before and after the patch. Hopefully it will make it easier to view. One can also use meld. Will also attach some results next.
<img alt="HowElioTested.sh" src="/jss/issue/raw/files/d81d3adcdc20539a0ad6273515f229cbbf9d0e21c241e9273986e9c50e89ca21-HowElioTested.sh" />
This file is the output of diff --unified sorted.warnings.before sorted.warnings.after > before-after-warnings.diff
<img alt="before-after-warnings.diff" src="/jss/issue/raw/files/5ce8c5755e268ed2f955d7acab2c5f78e6697014daa32001c5cfe4c84ffff678-before-after-warnings.diff" />
Revised version of the patch
Complete deprecation annotations already started - Addresses https://pagure.io/jss/issue/19 - Removed to depreactions as requestes on the review - see https://github.com/dogtagpki/jss/pull/26 - https://github.com/dogtagpki/jss/pull/26#pullrequestreview-159596877 - No deprecation annotions added to org/mozilla/jss/tests/Constants.java - until we clarify some issues
<img alt="PR26.patch" src="/jss/issue/raw/files/171738f132db6c056117e0cc1d15b053a1a01bb8ce4188d03b88c906e42830fd-PR26.patch" />
For review before I attempt doing a a revised pull request
This was fixed by jss PR#26. This was included in master by commit f38f62af.
Metadata Update from @cipherboy: - Custom field component adjusted to None - Custom field feature adjusted to None - Custom field origin adjusted to None - Custom field proposedmilestone adjusted to None - Custom field proposedpriority adjusted to None - Custom field reviewer adjusted to None - Custom field type adjusted to None - Custom field version adjusted to None - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
Metadata Update from @cipherboy: - Issue assigned to cipherboy
Login to comment on this ticket.