PR#97: String-type config options set to empty string shouldn't turn into None - ipsilon

ipsilon

#97 String-type config options set to empty string shouldn't turn into None

Merged 7 years ago by merlinthp. Opened 7 years ago by merlinthp.

merlinthp/ipsilon master into master

String-type config options set to empty string shouldn't turn into None

Howard Johnson • 7 years ago

ff689c8

ipsilon/util/config.py

file modified

+1 -1

		`@@ -133,7 +133,7 @@`
		`raise NotImplementedError`

		`def _str_export_value(self):`
		`- if self._assigned_value:`
		`+ if self._assigned_value is not None:`
		`return str(self._assigned_value)`
		`return None`

merlinthp commented 7 years ago

Without this, if we try to set a string-type config option to '' it becomes
None. When code expecting a string uses this value, it ends up expanding
out to 'None' in various places, including the plugin configuration pages.

Signed-off-by: Howard Johnson merlin@merlinthp.org

merlinthp commented 7 years ago

Simple reproducer for the issue: