#96 Styled the user consent page for openID Connect
Merged 7 years ago by merlinthp. Opened 7 years ago by ryanlerch.
Unknown source master  into  master

No commits found

This styles up the user consent page for openID Connect.
It presents the list of items to consent centered in
the middle of a fluid full-page layout, with the
user action to accept or reject at the bottom of the
list

There is a new master-user template that this page now
uses to display the content, as the the master template
uses the login-pf layout that does not work well with
long lists of content.

Signed-off-by: Ryan Lerch rlerch@redhat.com

Hi,

Thanks for the work on this!
The only two remarks I have is that the Reject button's on-mouseover looks wrong, and the backend sort of repeats on bigger displays.
Could you please look at fixing those, as I have no idea how to do that? :)

Thanks,
Ptarick

rebased

7 years ago

This file is regenerated from less/styles.less, so these changes need to be made in both files, or this'll be blown away the next time someone runs "make ui[-node]". (I'd make the changes to both files by hand though, as I've yet to find a version of lesscpy or lessc that doesn't make lots of pointless changes to the css output).

OK, so I've gotten around to having a look at this. Branch pr96 in my fork (https://pagure.io/fork/merlinthp/ipsilon/branch/pr96) is based on current master and Ryan's PR, with a few fixes: 1) the background image properly stretches, like it does on the login page, 2) the reject button is now styled as a link, like the login page's "Cancel" button, and 3) the CSS changes have been made in less/styes.less, and the styles.css regenerated with lessc.

I've not generated my own PR yet.

Ryan, do you want to have a look at my branch, and grab any bits you want from it?

Commit 8e22bf6 fixes this pull-request

Pull-Request has been merged by merlin@merlinthp.org

7 years ago
Metadata