PR#94: Enable OIDC autosubmit and urlencode return url - ipsilon

ipsilon

#94 Enable OIDC autosubmit and urlencode return url

Merged 7 years ago by puiterwijk. Opened 7 years ago by puiterwijk.

puiterwijk/ipsilon use-urlencode into master

openidc: Uncomment the autocommit in form response mode

Patrick Uiterwijk • 7 years ago

79459c2

openidc: Use urlencode to generate return URL

Patrick Uiterwijk • 7 years ago

34f4fb4

ipsilon/providers/openidc/auth.py

file modified

+2 -2

		`@@ -19,6 +19,7 @@`
		`import requests`
		`import time`
		`import json`
		`+ import urllib`
		`from urlparse import urlparse`

		`URLROOT = 'openidc'`
		`@@ -98,7 +99,6 @@`
		`# Build a response-string, which is sent with either query, form`
		`# or fragment responses`
		`if response_mode in ['query', 'fragment']:`
		`- data = ['%s=%s' % (key, contents[key]) for key in contents.keys()]`

		`separator = '?'`
		`if response_mode == 'fragment':`
		`@@ -108,7 +108,7 @@`
		`else:`
		`url += '&'`

		`- url += '&'.join(data)`
		`+ url += urllib.urlencode(contents)`

		`if response_mode in ['query', 'fragment', 'none']:`
		`raise cherrypy.HTTPRedirect(url)`

templates/openidc/form_response.html

file modified

+1 -2

		`@@ -17,7 +17,6 @@`
		`</div>`

		`<script type="text/javascript">`
		`- // TODO: Uncomment this, this is used for testing`
		`- //document.getElementById('openidc_response_form').submit();`
		`+ document.getElementById('openidc_response_form').submit();`
pingou commented 7 years ago Is this executed everytime the page is loaded?
alert("boo! (puiterwijk was here)"); Uiterwijk (puiterwijk)">puiterwijk commented 7 years ago Yep. Because the only goal of this page is to submit the information back to the Relying Party. This will make it a more seamless experience for the user.
pingou commented 7 years ago Should we wait for the page to be fully loaded?
alert("boo! (puiterwijk was here)"); Uiterwijk (puiterwijk)">puiterwijk commented 7 years ago Well, the form is the only thing that matters for this script, and it's in front of this in the html file.
		`</script>`
		`{% endblock %}`

no initial comment

pingou commented on line 7 of templates/openidc/form_response.html 7 years ago

Is this executed everytime the page is loaded?

puiterwijk commented on line 7 of templates/openidc/form_response.html 7 years ago

Yep. Because the only goal of this page is to submit the information back to the Relying Party.
This will make it a more seamless experience for the user.

pingou commented on line 7 of templates/openidc/form_response.html 7 years ago

Should we wait for the page to be fully loaded?

pingou commented 7 years ago

One question, otherwise :thumbsup: for me

puiterwijk commented on line 7 of templates/openidc/form_response.html 7 years ago

Well, the form is the only thing that matters for this script, and it's in front of this in the html file.

pingou commented 7 years ago

Thanks for your answer, my :thumbsup: remains :)