Is there no chance that create_plugin_data_table() can raise an exception?

There is, but that should be caught with the more global wrappers. The try/catch that I've moved it out of is only meant to make sure that we don't leave stuff in upgrade mode in case of errors (it doesn't have an Except clause, only a Finally).

Can you add that to the commit message, that callers are expected to catch this?

Functionally the patch is ok.

Updated the commit message.

ACK

This has been merged.