PR#53: Error messages missing value for format-specifier - ipsilon

John Dennis • 8 years ago

c9400d4

ipsilon/install/ipsilon-server-install

file modified

+4 -2

		`@@ -410,7 +410,8 @@`
		`return args`

		`if len(args['hostname'].split('.')) < 2:`
		`- raise ConfigurationError('Hostname: %s is not a FQDN')`
		`+ raise ConfigurationError('Hostname: %s is not a FQDN' %`
		`+ args['hostname'])`

		`for plugin_group in plugins:`
		`for plugin_name in plugins[plugin_group]:`
		`@@ -420,7 +421,8 @@`
		`try:`
		`pwd.getpwnam(args['system_user'])`
		`except KeyError:`
		`- raise ConfigurationError('User: %s not found on the system')`
		`+ raise ConfigurationError('User: %s not found on the system' %`
		`+ args['system_user'])`
rcritten commented 8 years ago I don't have the code in front of me but is args['system_user'] assured? If 'system_user' isn't in the args dict then it too will throw a KeyError.
jdennis commented 8 years ago Yes, it's guaranteed, defaults to ipsilon parser.add_argument('--system-user', default='ipsilon',

		`if args['lm_order'] is None:`
		`args['lm_order'] = []`

no initial comment

I don't have the code in front of me but is args['system_user'] assured? If 'system_user' isn't in the args dict then it too will throw a KeyError.

Yes, it's guaranteed, defaults to ipsilon

    parser.add_argument('--system-user', default='ipsilon',

OK, ACK then.

(note: this has been merged with Rob's ack. Had to hit the Close button because of a bug in Pagure).

Assignee

None

Tags

No Tags