ipsilon

#379 Fix refreshable_until for OpenIDC
Closed by abompard. Opened by puiterwijk.
puiterwijk/ipsilon fix_refreshable_until  into  master

Download 379.patch

This ensures that tokens are refreshable until the time they expire,
instead of being refreshable after refreshable_until time has expired.

Signed-off-by: Patrick Uiterwijk patrick@puiterwijk.org

Pull-Request has been closed by puiterwijk

Pull-Request has been reopened by puiterwijk

Maybe I'm reading this backwards, but doesn't this read as "If the refreshable_until value is earlier than the current time, don't refresh it"?

That's exactly right, and that's what's intended.
refreshable_until is the deadline until when the token can be refreshed.

So the new code is saying: if the deadline of refreshability is in the past, do not refresh anymore.

(For the record, I authored this line of code many years ago, and even just now it totally broke my brain to debug and rationalize why this patch is correct in my brain)

Huh I was just debugging that and arrived at the same conclusion :-)
Fixed in 5d0b7d8
Thanks folks!

Pull-Request has been closed by abompard

Right, I see how it works now. Thanks to both of you for fixing this!
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.