PR#340: providers/openidc: Do not stringify empty array for 'amr' when setting up auth response - ipsilon

ipsilon

#340 providers/openidc: Do not stringify empty array for 'amr' when setting up auth response

Merged 4 years ago by ngompa. Opened 4 years ago by ngompa.

ngompa/ipsilon oidc-amr-json into master

providers/openidc: Do not stringify empty array for 'amr' when setting up auth response

Neal Gompa • 4 years ago

c90a76b

ipsilon/providers/openidc/auth.py

file modified

+1 -1

		`@@ -503,7 +503,7 @@`
		`if 'nonce' in request:`
		`id_token['nonce'] = request['nonce']`
		`id_token['acr'] = '0'`
		`- id_token['amr'] = json.dumps([])`
		`+ id_token['amr'] = []`
simo commented 4 years ago Is this 'amr' even used? I see no other reference in the file.
		`id_token['azp'] = request['client_id']`

		`if 'code' in response:`

ngompa commented 4 years ago

We transform the whole authentication response dictionary into JSON later on, so
we do not need to do it while building the dictionary.

Fixes #339

Signed-off-by: Neal Gompa ngompa13@gmail.com

ngompa commented 4 years ago

@simo, could you please review this?

simo commented on line 6 of ipsilon/providers/openidc/auth.py 4 years ago

Is this 'amr' even used? I see no other reference in the file.

simo commented 4 years ago

Unfortunately I do not remember much of this provider, so I cannot say if this change is correct, it will change the serialization though. Are there any tests that verify this change is ok?

simo commented 4 years ago

Ah I read #339 now ... so there is in field proof this is wrong.

LGTM

ngompa commented 4 years ago

@simo We need to fix the test suite and get it running again in CI. Changes are scary without it...

Pull-Request has been merged by ngompa

4 years ago