#291 Update containertests to Fedora 26/27
Merged 6 years ago by puiterwijk. Opened 6 years ago by puiterwijk.
puiterwijk/ipsilon newfedora  into  master

file modified
+24 -24
@@ -8,7 +8,7 @@ 

  testdeps:

  	# Determine if test deps are installed

  	# First, some binaries

- 	which pylint

+ 	which pylint-2

  	which pep8

  	which httpd

  	which postgres
@@ -39,10 +39,10 @@ 

  lint:

  	# Analyze code

  	# don't show recommendations, info, comments, report

- 	# W0613 - unused argument

+         # W0613 - unused argument

  	# Ignore cherrypy class members as they are dynamically added

  	# Ignore IPA API class members as they are dynamically added

- 	pylint -d c,r,i,W0613 -r n -f colorized \

+ 	pylint-2 -d c,r,i,W0613 -r n -f colorized \

  		   --notes= \

  		   --ignored-classes=cherrypy,API \

  		   --disable=star-args \
@@ -73,7 +73,7 @@ 

  	git ls-files | xargs pycscope

  

  lp-test:

- 	pylint -d c,r,i,W0613 -r n -f colorized \

+ 	pylint-2 -d c,r,i,W0613 -r n -f colorized \

  		   --notes= \

  		   --ignored-classes=cherrypy \

  		   --disable=star-args \
@@ -141,17 +141,17 @@ 

  	@(cat tests/containers/Dockerfile-base tests/containers/Dockerfile-centos tests/containers/Dockerfile-rpm; echo "USER testuser") | sed -e 's/BASE/centos:7/' | docker build -f - -q -t ipsilon-centos7 -

  	@echo "CentOS 7 container built"

  

- container-fedora24:

- 	@echo "Building Fedora 24 container ..."

- 	@(cat tests/containers/Dockerfile-base tests/containers/Dockerfile-fedora tests/containers/Dockerfile-rpm; echo "USER testuser") | sed -e 's/BASE/fedora:24/' | docker build -f - -q -t ipsilon-fedora24 -

- 	@echo "Fedora 24 container built"

+ container-fedora26:

+ 	@echo "Building Fedora 26 container ..."

+ 	@(cat tests/containers/Dockerfile-base tests/containers/Dockerfile-fedora tests/containers/Dockerfile-rpm; echo "USER testuser") | sed -e 's/BASE/fedora:26/' | docker build -f - -q -t ipsilon-fedora26 -

+ 	@echo "Fedora 26 container built"

  

- container-fedora25:

- 	@echo "Building Fedora 25 container ..."

- 	@(cat tests/containers/Dockerfile-base tests/containers/Dockerfile-fedora tests/containers/Dockerfile-rpm; echo "USER testuser") | sed -e 's/BASE/fedora:25/' | docker build -f - -q -t ipsilon-fedora25 -

- 	@echo "Fedora 25 container built"

+ container-fedora27:

+ 	@echo "Building Fedora 27 container ..."

+ 	@(cat tests/containers/Dockerfile-base tests/containers/Dockerfile-fedora tests/containers/Dockerfile-rpm; echo "USER testuser") | sed -e 's/BASE/fedora:27/' | docker build -f - -q -t ipsilon-fedora27 -

+ 	@echo "Fedora 27 container built"

  

- containers: container-centos6 container-centos7 container-fedora24 container-fedora25

+ containers: container-centos6 container-centos7 container-fedora26 container-fedora27

  	@echo "Containers built"

  

  containertest-centos6: container-centos6
@@ -163,20 +163,20 @@ 

  	@docker run -v `pwd`:/code -t --rm ipsilon-centos7

  	@echo "CentOS 7 passed"

  

- containertest-fedora24: container-fedora24

- 	@echo "Starting Fedora 24 tests ..."

- 	@docker run -v `pwd`:/code -t --rm ipsilon-fedora24

- 	@echo "Fedora 24 passed"

+ containertest-fedora26: container-fedora26

+ 	@echo "Starting Fedora 26 tests ..."

+ 	@docker run -v `pwd`:/code -t --rm ipsilon-fedora26

+ 	@echo "Fedora 26 passed"

  

- containertest-fedora25: container-fedora25

- 	@echo "Starting Fedora 25 tests ..."

- 	@docker run -v `pwd`:/code -t --rm ipsilon-fedora25

- 	@echo "Fedora 25 passed"

+ containertest-fedora27: container-fedora27

+ 	@echo "Starting Fedora 27 tests ..."

+ 	@docker run -v `pwd`:/code -t --rm ipsilon-fedora27

+ 	@echo "Fedora 27 passed"

  

- containertest-lint: container-fedora25

+ containertest-lint: container-centos7

  	@echo "Starting code lint tests ..."

- 	@docker run -v `pwd`:/code -t --rm --entrypoint /usr/bin/make ipsilon-fedora25 lint pep8

+ 	@docker run -v `pwd`:/code -t --rm --entrypoint /usr/bin/make ipsilon-centos7 lint pep8

  	@echo "Code lint tests passed"

  

- containertest: containertest-lint containertest-centos6 containertest-centos7 containertest-fedora24 containertest-fedora25

+ containertest: containertest-lint containertest-centos6 containertest-centos7 containertest-fedora26 containertest-fedora27

  	@echo "Container tests passed"

@@ -1,1 +1,1 @@ 

- RUN yum install -y etcd python-etcd

+ RUN yum install -y etcd python2-python-etcd dbus-python python2-ipalib

@@ -2,7 +2,7 @@ 

      && yum install -y which

  # This should be kept in sync with the develop page on the website.

  # Distro-specific packages should go in the distro sub-dockerfiles.

- RUN yum install -y make pylint python-pep8 python-openid python-openid-teams \

+ RUN yum install -y make python2-pylint python-pep8 python-openid python-openid-teams \

          python-openid-cla python-cherrypy m2crypto lasso-python \

          python-sqlalchemy python-ldap python-pam python-fedora \

          freeipa-python httpd mod_auth_mellon postgresql-server \

no initial comment

Hm, this breaks the build on older OSes where the python 2.x pylint is still /usr/bin/pylint. How much do we care about that?

This breaks for F24 (EOL for 6 months) and earlier, and EL6.
It's never worked for EL6 anyway because pylint isn't packaged for it.
So, I think I'm going with "that's fine".

My opinion: you should not run security software on a 6-months EOL'd OS anyway :).

Yeah, all makes sense. I forgot to check if RHEL 7 had pylint-2, which is really as "old" as I care about now. +1 LGTM.

Commit 2856794 fixes this pull-request

Pull-Request has been merged by puiterwijk@redhat.com

6 years ago

Commit 84b0b21 fixes this pull-request

Pull-Request has been merged by puiterwijk@redhat.com

6 years ago

Commit 547dc9b fixes this pull-request

Pull-Request has been merged by puiterwijk@redhat.com

6 years ago