#285 Do not send SAML attributes we have no value for
Merged 3 years ago by puiterwijk. Opened 3 years ago by puiterwijk.
puiterwijk/ipsilon no-None-attributes  into  master

@@ -341,6 +341,9 @@ 

              attr.attributeValue = []

              vals = []

              for value in values:

+                 if value is None:

+                     self.log('Ignoring None value for attribute %s' % key)

Are you logging at this level for visibility to admins to know what is going on? Does this have the chance of spamming the log?

This is intended so the admins know what is going on, and also that they probably need to look at their account system, since it provided a value that was explicitly None. (this is a bug in the info or login module where it didn't just ignore an unset variable).

+                     continue

                  self.debug('value %s' % value)

                  node = lasso.MiscTextNode.newWithString(value)

                  node.textChild = True

Are you logging at this level for visibility to admins to know what is going on? Does this have the chance of spamming the log?

This is intended so the admins know what is going on, and also that they probably need to look at their account system, since it provided a value that was explicitly None. (this is a bug in the info or login module where it didn't just ignore an unset variable).

Commit 3eabc19 fixes this pull-request

Pull-Request has been merged by patrick@puiterwijk.org

3 years ago