PR#285: Do not send SAML attributes we have no value for - ipsilon

ipsilon

#285 Do not send SAML attributes we have no value for

Merged 6 years ago by puiterwijk. Opened 6 years ago by puiterwijk.

puiterwijk/ipsilon no-None-attributes into master

Do not send SAML attributes we have no value for

Patrick Uiterwijk • 6 years ago

aa0c1f5

file modified

		`@@ -341,6 +341,9 @@`
		`attr.attributeValue = []`
		`vals = []`
		`for value in values:`
		`+ if value is None:`
		`+ self.log('Ignoring None value for attribute %s' % key)`
rcritten commented 6 years ago Are you logging at this level for visibility to admins to know what is going on? Does this have the chance of spamming the log?
alert("boo! (puiterwijk was here)"); Uiterwijk (puiterwijk)">puiterwijk commented 6 years ago This is intended so the admins know what is going on, and also that they probably need to look at their account system, since it provided a value that was explicitly None. (this is a bug in the info or login module where it didn't just ignore an unset variable).
		`+ continue`
		`self.debug('value %s' % value)`
		`node = lasso.MiscTextNode.newWithString(value)`
		`node.textChild = True`

puiterwijk commented 6 years ago

Signed-off-by: Patrick Uiterwijk patrick@puiterwijk.org

rcritten commented on line 6 of ipsilon/providers/saml2/auth.py 6 years ago

Are you logging at this level for visibility to admins to know what is going on? Does this have the chance of spamming the log?

puiterwijk commented on line 6 of ipsilon/providers/saml2/auth.py 6 years ago

This is intended so the admins know what is going on, and also that they probably need to look at their account system, since it provided a value that was explicitly None. (this is a bug in the info or login module where it didn't just ignore an unset variable).

rcritten commented 6 years ago

Ok, ACK.

puiterwijk commented 6 years ago

Commit 3eabc19 fixes this pull-request

Pull-Request has been merged by patrick@puiterwijk.org

6 years ago