#156 Fix UserInfo signing by adding the field to the SP configuration
Merged 7 years ago by puiterwijk. Opened 7 years ago by puiterwijk.
puiterwijk/ipsilon fix-userinfo-signing  into  master

@@ -345,6 +345,12 @@ 

                  ['RS256'],

                  self.get_current_info('id_token_signed_response_alg'),

                  readonly=self.readonly),

+             pconfig.Pick(

+                 'UserInfo Signed Response Alg',

+                 'Algorithm used to sign userinfo',

+                 ['', 'RS256'],

+                 self.get_current_info('userinfo_signed_response_alg'),

I assume get_current_info() already knows how to fetch this data?

It will use the last fallback of '', which is just fine (since the code that deals with this expects something Falsey).

+                 readonly=self.readonly),

              pconfig.String(

                  'Initiate Login URI',

                  'URI that third party can use to initiate login at client.',
@@ -363,7 +369,6 @@ 

              # TODO:

              # id_token_encrypted_response_alg

              # id_token_encrypted_response_enc

-             # userinfo_signed_response_alg

              # userinfo_encrypted_response_alg

              # userinfo_encrypted_response_enc

              # request_object_signing_alg (defualt none)

I assume get_current_info() already knows how to fetch this data?

It will use the last fallback of '', which is just fine (since the code that deals with this expects something Falsey).

For consistency sake, I can also add a none option here and use that if preferred.

Nah, I just wanted to make sure that the patch wasn't missing some code. +1 from me.

Commit dc63e2f fixes this pull-request

Pull-Request has been merged by puiterwijk@redhat.com

7 years ago
Metadata