ipsilon

Clone
Source Code
GIT

#150 Small fixes with infosssd
Merged 7 years ago by puiterwijk. Opened 7 years ago by puiterwijk.
puiterwijk/ipsilon infosssd-fix-domains  into  master

file modified
+1 
@@ -184,5 +184,6 @@ 
 

          if 'gssapi' not in opts['lm_order']:
 

              opts['lm_order'].insert(0, 'gssapi')
 

          opts['form'] = 'yes'
 

+         opts['info_sssd'] = 'yes'
 

          if not any(lm in opts['lm_order'] for lm in ('form', 'pam')):
 

              opts['lm_order'].append('form')

file modified
+5 
@@ -247,6 +247,11 @@ 
 

          po.save_enabled_state()
 

  

      def unconfigure(self, opts, changes):
 

+         if 'domains' not in changes:
 

+             # We always record domains on configure, if we don't have that, we
 

+             # were not configured.
 

+             return
 

+ 

          try:
 

              sssdconfig = SSSDConfig.SSSDConfig()
 

              sssdconfig.import_config()

no initial comment

rebased
7 years ago

+1 Looks good to me

If something has gone wrong, should we raise an Exception here?

No, because the fact that we get here isn't a problem in itself. That just means that we weren't configured on installation, in which case we shouldn't do anything for uninstallation.
That's not an issue, just expected.

In that case, can you change the comment to state that instead of saying something went wrong? Maybe a "The installation didn't record a domain, so there is nothing to do here."?

rebased
7 years ago

Maybe s/, we I/. I/

LGTM otherwise!

rebased
7 years ago

I suggest fixing that typo, but I don't need to re-review if you do. LGTM!

rebased
7 years ago

Pull-Request has been merged by puiterwijk
7 years ago
Changes Summary 2
+1 -0
file changed
ipsilon/helpers/ipa.py
+5 -0
file changed
ipsilon/info/infosssd.py
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.