PR#135: Create an infofas plugin - - Pagure.io

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.

ipsilon

#135 Create an infofas plugin

Merged Oct 17, 2016 by puiterwijk. Opened Oct 14, 2016 by puiterwijk.

puiterwijk/ipsilon fasinfo into master

Download 135.patch

puiterwijk commented Oct 14, 2016

This will allow us to use FAS data even when the user was not
authenticated with FAS.

Signed-off-by: Patrick Uiterwijk puiterwijk@redhat.com

rebased

Oct 16, 2016

pingou commented Oct 17, 2016

Shouldn't the copyright be 2016 only?

pingou commented Oct 17, 2016

maybe a .lower()?

pingou commented Oct 17, 2016

Two questions, the rest looks good to me

puiterwijk commented Oct 17, 2016

Some of the code (like the fas_make_userdata) comes from 2014.

puiterwijk commented Oct 17, 2016

Selecting YES would not work, since then argparse would crash. Choices allows only yes and no.

pingou commented Oct 17, 2016

:thumbsup: for me

puiterwijk commented Oct 17, 2016

Thanks!

rebased

Oct 17, 2016

Pull-Request has been merged by puiterwijk

Oct 17, 2016

Metadata

Assignee

None

Tags

No Tags

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.