PR#120: Fix cleanup type issues with non-sqlite backends -

ipsilon

#120 Fix cleanup type issues with non-sqlite backends

Merged Sep 20, 2016 by puiterwijk. Opened Sep 13, 2016 by puiterwijk.

puiterwijk/ipsilon fix-cleanup-type-error into master

puiterwijk commented Sep 13, 2016

We store the data as strings, so when telling SQL to compare, we should be
sending strings to compare against.
SQLite does not actually check types, so doesn't throw this error, but for
example in Postgres, the following error is being recorded:
ProgrammingError: (psycopg2.ProgrammingError) operator does not exist: text <= timestamp without time zone

Signed-off-by: Patrick Uiterwijk puiterwijk@redhat.com

pingou commented Sep 13, 2016

Looks fine to me, :thumbsup:

merlinthp commented Sep 13, 2016

+1 here too

pingou commented Sep 20, 2016

@puiterwijk should we merge?

puiterwijk commented Sep 20, 2016

Yes, I should. And will.
Thanks for the ping.

puiterwijk commented Sep 20, 2016

Commit c736c0f0 fixes this pull-request

Pull-Request has been merged by puiterwijk@redhat.com