#101 Fix naming collissions in OpenIDC token refresh
Merged 7 years ago by puiterwijk. Opened 7 years ago by puiterwijk.
puiterwijk/ipsilon openidc-fixes  into  master

@@ -105,6 +105,8 @@ 

  

          self.save_unique_data('token', {token_id: token})

  

+         token['token_id'] = token_id

+ 

      def refreshToken(self, refresh_token, client_id):

          token = self.lookupToken(refresh_token, 'Refresh', True)

  
@@ -139,11 +141,11 @@ 

  

          self.update_token(token)

  

-         token = '%s_%s' % (token['token_id'], token_security_check)

+         new_token = '%s_%s' % (token['token_id'], token_security_check)

          refresh_token = 'R_%s_%s' % (token['token_id'], refresh_security_check)

  

          return {

-             'access_token': token,

+             'access_token': new_token,

              'refresh_token': refresh_token,

              'expires_in': expires_in

          }

Without this, refreshing a token would fail because token would
become a string, overwriting the dict that was there before, while
we still need to use parts of the dict later on.

Signed-off-by: Patrick Uiterwijk puiterwijk@redhat.com

Sounds like a good idea, :thumbsup: for me :)

rebased

7 years ago

Pull-Request has been merged by puiterwijk

7 years ago
Metadata